RFR(XS): Trivial: 8199880: runtime/appcds/condy/CondyHelloTest.java missing at requires vm.cds

Jiangli Zhou jiangli.zhou at oracle.com
Wed Mar 21 18:38:03 UTC 2018


+1

Thanks,
Jiangli

> On Mar 21, 2018, at 11:36 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> Thumbs up.
> 
> Dan
> 
> 
> On 3/21/18 2:26 PM, mikhailo wrote:
>> I believe this qualifies as a trivial fix. Please review.
>> 
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8199880
>>     Testing:
>>         1. Ran the affected test locally (Linux-x64)  with and w/o UseCompressedOops
>> 
>>     Diff:
>>         --- a/test/hotspot/jtreg/runtime/appcds/condy/CondyHelloTest.java
>>         +++ b/test/hotspot/jtreg/runtime/appcds/condy/CondyHelloTest.java
>>         @@ -24,7 +24,7 @@
>>         /*
>>         * @test
>>         * @summary Make sure CDS works with a minimal test case that uses a CONSTANT_Dynamic constant-pool entry
>>         - * @requires os.arch != "sparcv9"
>>         + * @requires (os.arch != "sparcv9") & (*vm.cds*)
>>         * @modules java.base/jdk.internal.misc
>>         * @library /test/lib /test/hotspot/jtreg/runtime/appcds
>>         * @build CondyHello
>> 
>> 
>> Thank you,
>> Misha
>> 
>> 
> 



More information about the hotspot-runtime-dev mailing list