RFR(M): 8199852: Print more information about class loaders in LinkageErrors.

[Lindenmaier, Goetz]

Hi George, 

I will update the copyrights. 

Thanks for the review!

Best regards,
  Goetz.


> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of George Triantafillou
> Sent: Donnerstag, 22. März 2018 18:53
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(M): 8199852: Print more information about class loaders in
> LinkageErrors.
> 
> Hi Goetz,
> 
> Some of the copyrights for new files need to be updated:
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_A.java.html
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_B.java.html
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> 26 // loading it's second version with Loader2.
> 26 // loading its second version with Loader2.
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_C.java.html
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_D_ambgs.jas
> m.html
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_D_ambgs.java
> .html
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> 35         // Since I need to use a yet different loader, I need to make
> an unknown
> 35         // Since I need to use a different loader, I need to make an
> unknown
> 
> 37         // unknown call, with but a single implementor so the
> compiler can do the
> 37         // unknown call, but with a single implementor so the
> compiler can do the
> 
> test/hotspot/jtreg/runtime/exceptionMsgs/LinkageError/LE2_Loader.java.h
> tml
> Remove 2010 from Copyright:
> 2  * Copyright (c) 2010, 2018, Oracle and/or its affiliates. All rights
> reserved.
> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> Otherwise, it looks good.
> 
> -George
> 
> 
> On 3/21/2018 7:55 AM, Lindenmaier, Goetz wrote:
> > Hi, ClassLoaders have a field containing a name since Java 9. This
> > change improves some of the messages of LinkageErrors to print the
> > name of the loader involved, as well as the parent of the loader. This
> > simplifies tracking down the component causing an error in large Java
> > systems. Please review:
> > http://cr.openjdk.java.net/~goetz/wr18/8199852-
> exMsg_Linkage/01/index.html
> > I ran this through all our tests (jck, jtreg, spec etc). I will run it
> > through submit-hs (or jdk/submit) once it's reviewed. Best regards,
> > Goetz.