RFR: 8200424: Windows build fails due to implicit jboolean to bool conversion
Aleksey Shipilev
shade at redhat.com
Thu Mar 29 12:56:18 UTC 2018
On 03/29/2018 02:57 PM, Claes Redestad wrote:
> TIL implicit conversions from jboolean to bool results in build failures on windows
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200424
>
> Patch:
>
> diff -r 2ad3212a7dd9 src/hotspot/share/prims/methodHandles.cpp
> --- a/src/hotspot/share/prims/methodHandles.cpp Thu Mar 29 10:38:29 2018 +0200
> +++ b/src/hotspot/share/prims/methodHandles.cpp Thu Mar 29 13:54:32 2018 +0200
> @@ -1226,7 +1226,7 @@
>
> Klass* caller = caller_jh == NULL ? NULL :
> java_lang_Class::as_Klass(JNIHandles::resolve_non_null(caller_jh));
> - Handle resolved = MethodHandles::resolve_MemberName(mname, caller, speculative_resolve,
> + Handle resolved = MethodHandles::resolve_MemberName(mname, caller, speculative_resolve == JNI_TRUE,
> CHECK_NULL);
>
> if (resolved.is_null()) {
Yup, looks good.
-Aleksey
More information about the hotspot-runtime-dev
mailing list