(11) RFR (M) JDK-8189916: Dynamic Constant support for Sparc

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed May 2 21:47:35 UTC 2018


http://cr.openjdk.java.net/~lfoltan/bug_jdk8189916.0/webrev/src/hotspot/cpu/sparc/templateTable_sparc.cpp.udiff.html

+ { // Check for the null sentinel.
+ // If we just called the VM, that already did the mapping for us,
+ // but it's harmless to retry.

Can you change 'that' to 'it' in the comments in all the platforms?

+ // Safe to call w ith 0 result


typo.

Looks good!
Coleen

On 5/2/18 4:21 PM, Lois Foltan wrote:
> Please review this change to the template interpreter to support 
> dynamic constant on Sparc.
>
> open webrev at 
> http://cr.openjdk.java.net/~lfoltan/bug_jdk8189916.0/webrev/
> bug link https://bugs.openjdk.java.net/browse/JDK-8189916
>
> All current jtreg dynamic constant tests pass when run on Sparc and 
> have had (os.arch != "sparcv9") removed from their test description.
>
> Testing: Sparc specific testing (hs-tier1-5, jdk-tier1-3) complete.
>                All tier 1 platforms (hs-tier1-2) in progress.
>
> Thanks,
> Lois
>



More information about the hotspot-runtime-dev mailing list