RFR(xxs): 8185034: Cleanup and consolidate Metaspace coding

[Thomas Stüfe]

Thank you Coleen!

On Mon, May 7, 2018 at 3:29 PM,  <coleen.phillimore at oracle.com> wrote:
> This looks good to me.  Thank you for all the metaspace cleanups and for
> looking at the logging in detail.
> Coleen
>
>
>
> On 5/5/18 3:58 PM, Thomas Stüfe wrote:
>>
>> Hi all,
>>
>> May I get reviews please?
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8185034
>> Webrev:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8185034-cleanup-and-consolidate-metaspace-coding/webrev.00/webrev/
>>
>> Despite the title this item is quite unexciting.
>>
>> Most of the cleanups originally targeted by this item did already
>> happen as part of other enhancements
>> (https://bugs.openjdk.java.net/browse/JDK-8199430,
>> https://bugs.openjdk.java.net/browse/JDK-8202638).
>>
>> What is left are some smallish cleanups:
>> - removed some functions which were unused
>> - small changes to ~SpaceManager to avoid logging the same info twice
>> (chunk manager state)
>> - removed all LogStream::cr() calls which were needed because
>> ~LogStream() did not autoflush; but  8202303 did fix that, so the cr()
>> can go.
>>
>> Note that there are more things one could clean up, which may happen
>> in the future. Especially the split-up of metaspace.cpp, which is
>> still open (https://bugs.openjdk.java.net/browse/JDK-8176808). But for
>> now I would like to close this particular issue.
>>
>> Thanks!
>>
>> ..Thomas
>
>