RFR(S) 8200746: Remove FlagGuard class

[David Holmes]

Hi Gerard,

On 17/05/2018 4:06 AM, Gerard Ziemski wrote:
> Hi all,
> 
> Please review this small fix where we remove unused FlagGuard class and FLAG_GUARD macro from hotspot and gtests.

Well it seems only unused after you have removed its uses! Why does it 
turn out not to be needed in test_CollectorPolicy.cpp? Why is the whole 
test_globals.cpp no longer relevant?

The bug report should explain why we don't need these.

Thanks,
David

> https://bugs.openjdk.java.net/browse/JDK-8200746
> http://cr.openjdk.java.net/~gziemski/8200746_rev1/
> 
> Testing: mach5 hs-tier1,2
> 
> 
> cheers
>