RFR(XS): Fix issue with "8199852: Print more information about class loaders in LinkageErrors."

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri May 18 10:59:00 UTC 2018


Hi David, 

Thanks for looking at this!

> Looks okay but can you add a space back in:
Oops, there were two spaces, and I removed both ... added one again.

Best regards,
  Goetz.

> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Friday, May 18, 2018 11:27 AM
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(XS): Fix issue with "8199852: Print more information about
> class loaders in LinkageErrors."
> 
> Looks okay but can you add a space back in:
> 
> !     Symbol*name = k->name();
> 
> :)
> 
> Thanks,
> David
> 
> On 18/05/2018 7:09 PM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > Unfortunately I need to do a small follow up for my LinkageError change.
> > If parentNameOop is NULL, parentName remains NULL. It should be set to
> <unnamed>.
> > I actually saw a crash on solaris x86_64 with this.
> > I also remove some dead, leftover variables.
> >
> > Please review:
> > http://cr.openjdk.java.net/~goetz/wr18/8203400-exMsg-
> fixLinkageError/01/
> >
> > Best regards,
> >    Goetz.
> >


More information about the hotspot-runtime-dev mailing list