RFR (S) 8134537: Much nearly duplicated code for sun.misc.Signal support

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri May 18 12:21:36 UTC 2018



On 5/18/18 12:49 AM, David Holmes wrote:
> One minor thing - only noticed because of your other change:
>
> src/hotspot/os/posix/jvm_posix.cpp
>
> 33 // sun.misc.Signal
>
> It isn't sun.misc.Signal anymore :)

Okay, I'll change that.  There are other comments in the file that I 
didn't want to mess with, since I only newly have read this code.

Thanks,
Coleen

>
> Thanks,
> David
>
> On 18/05/2018 2:37 PM, David Holmes wrote:
>> Hi Coleen,
>>
>> That all seems fine to me. Nice cleanup. (Plenty more to go ;-) )
>>
>> Thanks,
>> David
>>
>> On 18/05/2018 6:26 AM, coleen.phillimore at oracle.com wrote:
>>> Summary: merged jvm_<os>.cpp into jvm_posix.cpp mostly
>>>
>>> See bug for more info.  The os_<os>.cpp code is sort of duplicated 
>>> but different enough to not be worth refactoring, for this feature.  
>>> I was in the area, so merged this one part.
>>>
>>> Tested with hs-tier1,2 runtime/signal tests and 
>>> sun/misc/SunMiscSignalTest.java.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8134537.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8134537
>>>
>>> Thanks,
>>> Coleen



More information about the hotspot-runtime-dev mailing list