RFR (S) 8202669: Intermittent crash in ClassLoadingService::compute_class_size()

[David Holmes]

Hi Coleen,

This looks good.

On 22/05/2018 9:01 AM, coleen.phillimore at oracle.com wrote:
> Summary: Don't report classes that failed to load when reporting class 
> unloading.  Remove the classes first.
> 
> Also add a NULL check for transitive_interfaces for safety, but the new 
> tests pass without it and fail without the fix.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8202669.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8202669

src/hotspot/share/classfile/classLoaderData.cpp

590   // after erroreous classes are released.

Typo: erroreous -> erroneous

---

test/hotspot/jtreg/runtime/BadObjectClass/TestLoadObject.java

56       byte[] buf = InMemoryJavaCompiler.compile("java.lang.Object", 
source,
  57                                         "--patch-module=java.base");

Indent is wrong on line 57.

I don't see why you need the two test programs as 
TestUnloadClassError.java tests both conditions.

No need to see a new webrev.

Thanks,
David
-----

> Tested with hs-tier1-5.
> 
> Thanks,
> Coleen