RFR(M): 8199257: [TESTBUG] Open source VM testbase metaspace tests

[coleen.phillimore at oracle.com]

On 5/10/18 5:39 PM, Mikhailo Seledtsov wrote:
> Hi Thomas,
>
> On 5/9/18, 9:01 AM, Thomas Stüfe wrote:
>> Not a review, but I ran these tests on my local machine (with my
>> current metaspace changes) and they all passed.
> Thank you.
>>
>> Will these tests be somehow merged with the existing metaspace tests
>> at runtime/Metaspace?
> We can consider this in the future. We can either collect them into 
> the same test group, or consider migrating the tests into a different 
> location/directory.

Yes, this is a good suggestion for a future RFE (once they are 
open-sourced).
>>
>> I think the general question is what is vmTestBase, and what sets the
>> tests in there apart from the existing tests outside vmTestBase?
> VM Testbase is a collection of tests used for testing HotSpot. There 
> are several things that set them apart from other JTReg HotSpot tests, 
> such as certain common conventions (coding conventions, keywords) and 
> common test libraries. There is a bit more info in this README file: 
> http://hg.openjdk.java.net/jdk/jdk/file/tip/test/hotspot/jtreg/vmTestbase/README.md
>


If moved to test/hotspot/jtreg/runtime/metaspace we'd have to be careful 
that the stress tests aren't run with earlier tiers.

thanks,
Coleen

>
> I hope I have answered your questions,
>
> Thank you,
> Misha
>>
>> Thanks, Thomas
>>
>>
>> On Tue, May 8, 2018 at 7:38 PM, 
>> mikhailo<mikhailo.seledtsov at oracle.com>  wrote:
>>> http://cr.openjdk.java.net/~mseledtsov/8199257.01.open/index.html
>>>
>>> Please review this change open sourcing VM metaspace tests. These 
>>> tests have
>>> been used internally for a while, and are now being open sourced. 
>>> Since this
>>> is not an creation of new tests, we would like to keep the changes 
>>> during
>>> this review to an absolute required minimum. If you have any 
>>> feedback on
>>> improvements of these tests, please file RFE(s) that will be 
>>> addressed later
>>> in order of priority.
>>>
>>>
>>> Here is what was done for this change:
>>>    1. Moved the tests to OpenJDK repository to the specified directory
>>> location and structure.
>>>    3. Updated Copyright statements accordingly.
>>>    4. Updated "@library" statements accordingly.
>>>    5. Updated TEST.groups and ProblemList.txt
>>>
>>>    JBS:    https://bugs.openjdk.java.net/browse/JDK-8199257
>>>    Webrev: 
>>> http://cr.openjdk.java.net/~mseledtsov/8199257.01.open/index.html
>>>
>>>    Testing:
>>>        1. Ran the following tests on open-only repository and build, 
>>> using
>>> "make run-test" (Linux-x64)
>>>           vmTestbase_vm_metaspace, vmTestbase_largepages
>>>           All PASS
>>>
>>>        2. Automated multip-platform test system (usual 4 platforms):
>>>           - vmTestbase_vm_metaspace, vmTestbase_largepages
>>>           - hs-tier{1,2,3}
>>>           All PASS
>>>
>>> Thank you,
>>> Misha
>>>