RFR (M): 8203881: Print errornous size in NegativeArraySizeException

[Thomas Stüfe]

On Mon, May 28, 2018 at 2:10 PM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi David,
>
> thanks for having a look!
>
>> First I have corrected the typo in the synopsis: errornous -> erroneous
> Thanks!
>
>> Second, can you not use the err_msg function instead of the explicit
>> ResourceMark + stringStream code?
> Yes, that's much better. New webrev:
> http://cr.openjdk.java.net/~goetz/wr18/8203881-exMsg-NegativeArraySize/02
>
> Best regards,
>   Goetz.
>

Hi Goetz,

looks good, but I would probably use a smaller Format Buffer. Default
(e.g. err_msg) uses 256 bytes of stack space, seems a bit much for a
single number.

Leave it up to you if you take the suggestion.

Thomas

p.s. that's not M :-)

>
>
>>
>> Thanks,
>> David
>>
>> On 28/05/2018 8:40 PM, Lindenmaier, Goetz wrote:
>> > Hi,
>> >
>> > This change adds printing the array size in case of negative array size
>> exception.
>> > Please review.
>> > http://cr.openjdk.java.net/~goetz/wr18/8203881-exMsg-
>> NegativeArraySize/01/
>> >
>> > Thanks,
>> >    Goetz.
>> >