RFR 8133564: Runtime - 2nd followup to Validate JVM Command-Line Flag Arguments

[Thomas Stüfe]

Okay thanks!

..Thomas

On Tue, May 29, 2018 at 7:15 PM, Gerard Ziemski
<gerard.ziemski at oracle.com> wrote:
> I’m on it.
>
> I merged manually and forgot “static” keyword.
>
>
> cheers
>
>> On May 29, 2018, at 12:09 PM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
>>
>> Hi guys,
>>
>> this change breaks all our builds.
>>
>> * For target hotspot_variant-server_libjvm_objs_jvmFlagConstraintsCMS.o:
>> /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp:
>> In function ‘JVMFlag::Error
>> ParallelGCThreadsAndCMSWorkQueueDrainThreshold(uint, uintx, bool)’:
>> /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp:42:43:
>> error: cannot call member function ‘void JVMFlag::printError(bool,
>> const char*, ...)’ without object
>>                         threads, threshold);
>>
>> (linux x64)
>>
>> --- a/src/hotspot/share/runtime/flags/jvmFlag.hpp Tue May 29 13:44:44 2018 +0200
>> +++ b/src/hotspot/share/runtime/flags/jvmFlag.hpp Tue May 29 11:04:56 2018 -0500
>> @@ -276,6 +276,7 @@
>>
>>   // printRanges will print out flags type, name and range values as
>> expected by -XX:+PrintFlagsRanges
>>   static void printFlags(outputStream* out, bool withComments, bool
>> printRanges = false, bool skipDefaults = false);
>> +  void printError(bool verbose, const char* msg, ...);
>>
>>   static void verify() PRODUCT_RETURN;
>>
>> printError in jvmFlags.hpp must be static.
>>
>> Please fix. Thanks.
>>
>> Best Regards, Thomas
>>
>>
>>
>> On Fri, May 25, 2018 at 10:29 PM, Gerard Ziemski
>> <gerard.ziemski at oracle.com> wrote:
>>> Thank you Harold!
>>>
>>>> On May 25, 2018, at 8:53 AM, Harold David Seigel <harold.seigel at oracle.com> wrote:
>>>>
>>>> The change looks good to me, also.
>>>>
>>>> Thanks, Harold
>>>>
>>>>
>>>> On 5/24/2018 11:53 AM, coleen.phillimore at oracle.com wrote:
>>>>>
>>>>> Very nice, thanks!
>>>>> Coleen
>>>>>
>>>>> On 5/24/18 11:50 AM, Gerard Ziemski wrote:
>>>>>> Thank you Coleen for your review.
>>>>>>
>>>>>> I fixed the indentation as well as the years in copyright header.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~gziemski/8133564_rev2
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8133564
>>>>>>
>>>>>>
>>>>>> cheers
>>>>>>
>>>>>>> On May 23, 2018, at 4:29 PM, coleen.phillimore at oracle.com wrote:
>>>>>>>
>>>>>>>
>>>>>>> This looks good apart from fixing the indentation of the arguments for all these changes so that they line up.
>>>>>>>
>>>>>>> - CommandLineError::print(verbose,
>>>>>>> + JVMFlag::printError(verbose,
>>>>>>>                             "ParallelGCThreads (" UINT32_FORMAT ") or CMSWorkQueueDrainThreshold ("
>>>>>>>                             UINTX_FORMAT ") is too large\n",
>>>>>>>                             threads, threshold);
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Coleen
>>>>>>>
>>>>>>> On 5/23/18 4:25 PM, Gerard Ziemski wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Please review this follow-up fix that cleans up the following:
>>>>>>>>
>>>>>>>> #1 We move the error print method out of jvmFlagRangeList and into jvmFlag, which allows us not to include jvmFlagRangeList.hpp just for the print method in various files
>>>>>>>>
>>>>>>>> #2 We cleanup "utilities/defaultStream.hpp” includes
>>>>>>>>
>>>>>>>> #3 and #4 in the issue are no longer applicable
>>>>>>>>
>>>>>>>> Tested locally with various debug/product, headers/no headers, open/closed variations, as well as Mach5 hs-tier1,tier2,tier3 tests, and Mach5 open/closed variations.
>>>>>>>>
>>>>>>>>
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8133564
>>>>>>>> http://cr.openjdk.java.net/~gziemski/8133564_rev1
>>>>>>>>
>>>>>>>> cheers
>>>>>
>>>>
>>>
>