RFR(s): 8203219: VM.metaspace jcmd should optionally show loaded classes for loaders

[coleen.phillimore at oracle.com]

On 5/30/18 11:09 AM, Thomas Stüfe wrote:
> Thank you Coleen!
>
> On Wed, May 30, 2018 at 4:57 PM,  <coleen.phillimore at oracle.com> wrote:
>> This seems okay.  There is already a jcmd VM.systemdictionary that prints
>> all the classes per class loader.
>>
> Would you be okay with still putting this improvement in? I think the
> added benefit for the users of VM.metaspace outweighs the additional
> cost in code complexity.

Since it's small and sort of different and the output seems compact 
enough, I think it's ok.   The system dictionary output shows class 
loading that has been initiated by each loader as well, so it's a 
different view of the information.

thanks,
Coleen

>
> Thanks, Thomas
>
>> Coleen
>>
>>
>> On 5/30/18 9:57 AM, Thomas Stüfe wrote:
>>> Ping...
>>>
>>> All tests passed on jdk-submit.
>>>
>>> Thanks for any reviews.
>>>
>>> Thomas
>>>
>>> On Sun, May 20, 2018 at 8:58 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
>>> wrote:
>>>> Hi all,
>>>>
>>>> can I have reviews for this small addition to the VM.metaspace jcmd,
>>>> which adds the ability to list classes loaded by each class loader?
>>>>
>>>> Thank you!
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8203219
>>>> webrev:
>>>> http://cr.openjdk.java.net/~stuefe/webrevs/8203219-VM.metaspace-show-loaded-classes/webrev.00/webrev/index.html
>>>>
>>>> Example output:
>>>>
>>>>
>>>> http://cr.openjdk.java.net/~stuefe/webrevs/8203219-VM.metaspace-show-loaded-classes/example.txt
>>>>
>>>> Kind Regards, Thomas
>>