RFR(xs): 8203960: [TESTBUG] runtime/logging/DefaultMethodsTest.java failed when running in CDS mode

[David Holmes]

Looks good.

Thanks,
David

On 31/05/2018 3:04 PM, Calvin Cheung wrote:
> Hi Ioi, David,
> 
> Thanks for your review and suggestion.
> 
> I've added a simple interface with a default method. The InnerClass 
> implements the interface.
> 
> Updated webrev:
>      http://cr.openjdk.java.net/~ccheung/8203960/webrev.01/
> 
> thanks,
> Calvin
> 
> 
> On 5/30/18, 9:16 PM, David Holmes wrote:
>> +1 the test should be self-sufficient and not rely on an unrelated 
>> module.
>>
>> Thanks,
>> David
>>
>> On 31/05/2018 2:03 PM, Ioi Lam wrote:
>>> Hi Calvin,
>>>
>>> Instead of relying on an internal JDK class to have default method 
>>> processing, maybe InnerClass should contain some code to ensure that 
>>> default method processing will always happen?
>>>
>>> Thanks
>>>
>>> - Ioi
>>>
>>>
>>> On 5/30/18 8:58 PM, Calvin Cheung wrote:
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8203960
>>>>
>>>> webrev: http://cr.openjdk.java.net/~ccheung/8203960/webrev.00/
>>>>
>>>> If this test is run in CDS mode, most of the system classes will be 
>>>> in the CDS archive and loading of those classes from the archive 
>>>> will bypass the default method processing. The test fails in CDS 
>>>> mode since it expects the trace output from default method processing.
>>>> A fix is to load an additional class which isn't in any of the 
>>>> modules defined by default. The loading of the additional class will 
>>>> trigger default method processing.
>>>>
>>>> Ran the test with and without CDS.
>>>> I will do a sanity hs-tier1 and hs-tier2 testing run.
>>>>
>>>> thanks,
>>>> Calvin
>>>