RFR (XS) 8213383 : Wrap up pthread_cond_wait into a loop to workaround potential spurious wakeups
David Holmes
david.holmes at oracle.com
Mon Nov 5 21:42:48 UTC 2018
Hi Ivan,
I hadn't realized this is hotspot code?
Your fix addresses exactly what you claimed.
I'll refrain on commenting on this code in general. ;-)
Thanks,
David
On 6/11/2018 5:59 AM, Ivan Gerasimov wrote:
> Hello!
>
> In src/java.base/unix/native/libjsig/jsig.c:
>
> signal_lock() makes all the thread that are not jvm wait while the later
> is installing signal handlers.
> This is done via a call to pthread_cond_wait().
> Spurious wakeups from pthread_cond_wait() are allowed, so it needs to be
> wrapped up into a loop.
>
> Would you please help review the trivial fix?
> Control build and testing of tier1,2,3 went fine on all supported
> platforms.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8213383
> WEBREV: http://cr.openjdk.java.net/~igerasim/8213383/00/webrev/
>
> Thanks!
>
More information about the hotspot-runtime-dev
mailing list