RFR(xxs): 8211845: A new switch to control verbosity of hs-err files

[Lindenmaier, Goetz]

Hi Thomas, 

the change looks good.

I maybe would not place the new flag at the end of the flags list, 
probably near the flag 'ErrorFile', i.e., thematically 
sorted.

Best regards,
  Goetz.



> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net>
> On Behalf Of Thomas Stüfe
> Sent: Mittwoch, 7. November 2018 12:08
> To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
> Subject: RFR(xxs): 8211845: A new switch to control verbosity of hs-err files
> 
> Hi all,
> 
> may I please have reviews for this patch:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211845
> 
> which is just the implementation of:
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8211846
> 
> cr: http://cr.openjdk.java.net/~stuefe/webrevs/8211845-extensive-error-
> reports-switch/webrev.00/webrev/
> 
> We wanted a switch which would allow us to add types of output to the
> hs-err files which may under standard conditions considered to be
> either too lengthy or too security sensitive. This switch would be off
> under normal conditions but could be switched on in trusted
> environments or when one does not care about the size of hs-err files.
> For further information, please see the CSR.
> 
> Please note that I refrained from adding "enable security sensitive
> output" or similar text to the switch description. The reason is that
> this would implicitly promise that by default, when this switch is off
> (like, now), the hs-err file does not contain security sensitive
> information. And that we just cannot promise. After all, we already
> print out register contents etc.
> 
> Thanks, Thomas