RFR(XS): 8213438: Remove ClearResponsibleAtSTW

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu Nov 8 19:48:45 UTC 2018


Thanks for the reviews. Change pushed!

Cheers,
Mikael


> On Nov 7, 2018, at 9:06 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> On 11/6/18 4:51 PM, Mikael Vidstedt wrote:
>> Please review this small change which removes an “unused” enum/value and some effectively dead code.
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8213438 <https://bugs.openjdk.java.net/browse/JDK-8213438>
>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213438/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213438/webrev.00/open/webrev/>
> 
> src/hotspot/share/runtime/synchronizer.cpp
>     No comments.
> 
> Thumbs up!
> 
> Dan
> 
> 
>> 
>> * Background (from jbs)
>> 
>> The ClearResponsibleAtSTW enum value in src/hotspot/share/runtime/synchronizer.cpp is set to 0 and only used in a single place:
>> 
>> if (ClearResponsibleAtSTW) mid->_Responsible = NULL;
>> 
>> Since the value is 0/false that code is effectively dead. The enum and the dead code should be removed.
>> 
>> * Testing
>> 
>> Built linux-x64-debug locally. Will run tier1 just to be extra sure.
>> 
>> Cheers,
>> Mikael
>> 
> 



More information about the hotspot-runtime-dev mailing list