RFR(S): 8213794: disable some tests for ARM32
Boris Ulasevich
boris.ulasevich at bell-sw.com
Wed Nov 14 14:03:48 UTC 2018
Hi David,
On 14.11.2018 7:56, David Holmes wrote:
> Hi Boris,
>
> There's a bit of a mix of things here that aren't all owned by runtime.
> But this seems simple enough.
Yes. I just wanted to avoid spamming mailing lists with three trivial
review requests.
> One query with the tests. Should we prefer a separate @requires for arm,
> or should we add to existing query for aarch64?
One line definitely looks more compact. Thanks!
- @requires os.arch != "aarch64"
- @requires os.arch != "arm"
+ @requires (os.arch != "aarch64") & (os.arch != "arm")
Updated webrev:
http://cr.openjdk.java.net/~bulasevich/8213794/webrev.02
> Thanks,
> David
>
> On 14/11/2018 2:05 am, Boris Ulasevich wrote:
>> Hi all,
>>
>> ARM32 implementation does not support TypeProfiling,
>> CriticalJNINatives and Serviceablity Agent. Tests are updated to take
>> it into account. Plus adding a warning message on wrong VM option
>> usage accordingly to similar change for aarch64[1].
>>
>> http://cr.openjdk.java.net/~bulasevich/8213794/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8213794
>>
>> thanks,
>> Boris
>>
>> [1]
>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2017-November/027658.html
>>
More information about the hotspot-runtime-dev
mailing list