RFR(s): 8212108: SafepointSynchronizer never ending counter (big enough)

David Holmes david.holmes at oracle.com
Thu Nov 22 09:58:26 UTC 2018


On 22/11/2018 7:35 pm, Robbin Ehn wrote:
> Hi David,
> 
>> Okay.
> 
> Okay as in reviewed ? :)

:) Yes.

David

> /Robbin
> 
>>
>> Thanks,
>> David
>>
>>>>
>>>> I'm not familiar with JFR types - is "ulong" guaranteed to be 64-bit?
>>>
>>> It translate to an u8, so yes.
>>>
>>>>
>>>>> Passes t1-3 and the two updated FR tests.
>>>>
>>>> Does any of that actually run long enough to overflow a 32-bit counter?
>>>
>>> We have no tests that run long enough to rollover.
>>>
>>> Thanks, Robbin
>>>
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>>
>>>>> Thanks Robbin


More information about the hotspot-runtime-dev mailing list