RFR(s): 8212108: SafepointSynchronizer never ending counter (big enough)

Robbin Ehn robbin.ehn at oracle.com
Sat Nov 24 20:34:58 UTC 2018


Thanks Dan, same here, me trigger happy again :(

So I can't credit you, sorry about that!

/Robbin

On 2018-11-24 15:16, Daniel D. Daugherty wrote:
> On 11/21/18 8:45 AM, Robbin Ehn wrote:
>> Hi all, please review.
>>
>> The counter can loop around, it would mainly be an issue in reading such flight-
>> recorder recording. I have two upcoming features which uses the fact that it is
>> always increasing.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8212108
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rehn/8212108/webrev/
> 
> src/hotspot/share/code/dependencyContext.hpp
>      No comments.
> 
> src/hotspot/share/jfr/metadata/metadata.xml
>      No comments.
> 
> src/hotspot/share/runtime/safepoint.cpp
>      No comments.
> 
> src/hotspot/share/runtime/safepoint.hpp
>      No comments.
> 
> test/jdk/jdk/jfr/event/runtime/TestBiasedLockRevocationEvents.java
>      No comments.
> 
> test/jdk/jdk/jfr/event/runtime/TestSafepointEvents.java
>      No comments.
> 
> Thumbs up.
> 
> Dan
> 
> 
>>
>> Passes t1-3 and the two updated FR tests.
>>
>> Thanks Robbin
> 


More information about the hotspot-runtime-dev mailing list