RFR(XS): 8202415: Incorrect time logged for monitor deflation

[David Holmes]

Hi Dan,

On 27/11/2018 5:36 am, Daniel D. Daugherty wrote:
> Greetings,
> 
> I have an extra small fix for the following bug:
> 
>      JDK-8202415 Incorrect time logged for monitor deflation
>      https://bugs.openjdk.java.net/browse/JDK-8202415
> 
> Here's the webrev URL:
> 
> http://cr.openjdk.java.net/~dcubed/8202415-webrev/0_for_jdk_jdk/

Why is it that you only track the time for

log_is_enabled(Debug, monitorinflation)

but you only report the time under:

log_info(safepoint, cleanup)

?? Unless you explicitly know to enable monitorinflation enabling the 
safepoint-cleanup logging will just report zero. I would have expected 
to see the deflation time recorded and printed for both log settings

And under what conditions is the existing "global deflation" time reported?

> The fix has been tested with a Mach5 builds-tier1,hs-tier1,jdk-tier1,
> hs-tier2,hs-tier3 job. The modified SafepointCleanupTest.java has
> been verified to pass in all Mach5 configs.

But the test doesn't enable monitorinflation logging so doesn't actually 
verify the logging works.

> This bug is currently targeted at jdk13, but I think it is safe
> enough to be pushed to jdk12 if the reviewers agree.

No problem with fixing in 12.

Thanks,
David

> Thanks, in advance, for any comments, questions or suggestions.
> 
> Dan