RFR(xxs): 8214229: Enable ShowRegistersOnAssert by default

[coleen.phillimore at oracle.com]

On 11/28/18 2:54 AM, Thomas Stüfe wrote:
> Thank you Coleen.
>
> For now I like to keep it switchable, just in case something goes
> wrong. Note that "something going wrong" means, worst case, that an
> assertion is hidden by a false segfault when accessing the assertion
> poison page.
>
> Still, I do not want to get chased by annoyed VM developers :) so for
> now I rather leave the switch in.

That's fine with me.
Thanks,
Coleen
>
> Thanks, Thomas
>
> On Wed, Nov 28, 2018 at 1:08 AM <coleen.phillimore at oracle.com> wrote:
>>
>> This seems fine with me.  Maybe we'll decide that this doesn't need to
>> be an option in the future.
>> Thanks,
>> Coleen
>>
>> On 11/22/18 6:21 AM, Thomas Stüfe wrote:
>>> Hi,
>>>
>>> 8191101 (Show register content in hs-err file on assert) added a small
>>> facility which would show register content in hs-err files at the
>>> point where asserts/guarantees happened.
>>>
>>> This feature has been very useful to us, and since its inception has
>>> been enabled by default in our nightlies without problems showing up.
>>> So we would like to enable this feature by default .
>>>
>>> Please note that this feature is stubbed out on Non-Linux platforms so
>>> this only affects Linux.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214229
>>> cr: http://cr.openjdk.java.net/~stuefe/webrevs/8214229-enable-ShowRegistersOnAssert-by-default/webrev.00/webrev/
>>>
>>> Thank you,
>>>
>>> Thomas