RFR (trivial) 8214356: Verification of class metadata unloading takes a long time
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Nov 29 18:33:53 UTC 2018
On 11/29/18 4:58 AM, Thomas Schatzl wrote:
> Hi Coleen,
>
> On Wed, 2018-11-28 at 20:06 -0500, coleen.phillimore at oracle.com wrote:
>> On 11/28/18 5:43 PM, Aleksey Shipilev wrote:
>>> On 11/28/18 11:34 PM, coleen.phillimore at oracle.com wrote:
> http://cr.openjdk.java.net/~coleenp/8214356.02/webrev/src/hotspot/share/memory/binaryTreeDictionary.inline.hpp.udiff.html
>>> Oh! I meant that since flag implies gating expensive ops, it does
>>> not need a comment. Does not hurt
>>> either way.
>> I guess it's expensive for CMS too... I left it in as a hint that
>> it's used for metaspace.
>>
>> Coleen
> looks good.
>
> Thanks for addressing this so quickly. Could you also revert the hack I
> did in https://bugs.openjdk.java.net/browse/JDK-8211211 as part of this
> change if you did not already push?
>
> That one-liner is not required any more with these changes.
Okay, I removed the options for CMS that you added to StressDictionary.
-XX:+IgnoreUnrecognizedVMOptions -XX:-CMSPrecleaningEnabled
Thank you for the detailed analysis of the problem.
Coleen
>
> Thanks,
> Thomas
>
>
More information about the hotspot-runtime-dev
mailing list