RFR(S): 8211714: Need to update vm_version.cpp to recognise VS2017 minor versions

[David Holmes]

On 9/10/2018 2:44 PM, David Holmes wrote:
> On 9/10/2018 2:37 PM, Mikael Vidstedt wrote:
>>
>> Is there some way to get the compiler to identify itself on the 
>> command line and have the build system pass that in perhaps?
> 
> Sure. Here's the output from configure:
> 
> jib > * Toolchain:      microsoft (Microsoft Visual Studio 2017 15.5.5 
> (devkit))
> 
> Should be relatively easy to pass that through to the build flags. I'll 
> file a RFE :)

We already allow for HOTSPOT_BUILD_COMPILER to be set externally, just 
nothing currently does :)

https://bugs.openjdk.java.net/browse/JDK-8211906

David

> Cheers,
> David
> 
> 
>> Cheers,
>> Mikael
>>
>>> On Oct 8, 2018, at 6:04 PM, David Holmes <david.holmes at oracle.com> 
>>> wrote:
>>>
>>> Looks fine - and trivial so only 1 review needed.
>>>
>>> I've often wondered why MS never defined a string literal for the 
>>> version so we wouldn't need this table ...
>>>
>>> Thanks,
>>> David
>>>
>>> On 8/10/2018 9:21 PM, Muthusamy Chinnathambi wrote:
>>>> Hi,
>>>> Please review this change to make hotspot aware of additional 
>>>> windows compiler versions.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211714
>>>> Webrev: http://cr.openjdk.java.net/~mchinnathamb/8211714/webrev.00/
>>>> Regards,
>>>> Muthusamy C
>>