RFR 8079784: Unexpected IllegalAccessError when trying access InnerClasses attribute

[Harold David Seigel]

Thanks Lois!

I'll incorporate those changes before I push the fix.

Harold


On 10/9/2018 1:11 PM, Lois Foltan wrote:
> On 10/9/2018 10:12 AM, Harold David Seigel wrote:
>
>> Hi,
>>
>> Please review this fix, proposed by Doug Simon, for JDK-8079784. The 
>> fix prevents classes in the InnerClasses attribute from being loaded 
>> unless they are actually being accessed.
>>
>> Also, while looking into this issue, I noticed that method 
>> is_same_package_member() is not used.  So, I removed it as part of 
>> this webrev.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8079784/webrev/
>>
>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8079784
>>
>> The fix was tested with the test in the webrev and by running Mach5 
>> tiers 1 and 2 tests and builds on Linux-x64, Windows, and Mac OS X, 
>> running tiers 3-5 tests on Linux-x64, and by running JCK-12 Lang and 
>> VM tests on Linux-x64.
>>
>> Thanks, Harold
>>
> Looks good!  One minor comment:
>
> - InnerClassesTest.jasm
> line #39,  "con/g/Base$Builder" should be "com/g/Base$Builder".
> line #41, maybe expand on the last sentence of the comment, "an IAE 
> for com/g/Base$Builder should not occur when the InnerClasses 
> attribute for class InnerClassesTest is being traversed to resolve 
> com/n/InnerClasses/Test$Foo."
>
> Don't need to see another webrev.
>
> Thanks,
> Lois