RFR (XS) 8212617: ARM32 build failures after JDK-7041262 (VM_Version should be called instead of Abstract_VM_Version so that overriding works)

Aleksey Shipilev shade at redhat.com
Wed Oct 17 18:02:52 UTC 2018


Bug:
  https://bugs.openjdk.java.net/browse/JDK-8212617

I think it fails because there is a left-over declaration in ARM header, which makes linker try to
find the definition, and failing.

Fix:

# HG changeset patch
# User shade
# Date 1539798253 -7200
#      Wed Oct 17 19:44:13 2018 +0200
# Node ID 050c046ef62bdee5b78bba0beec8f04f9a63a1b1
# Parent  92a18a1292533c334021aef21a66c5c9bc1b663c
8212617: ARM32 build failures after JDK-7041262 (VM_Version should be called instead of
Abstract_VM_Version so that overriding works)
Reviewed-by: XXX

diff -r 92a18a129253 -r 050c046ef62b src/hotspot/cpu/arm/vm_version_arm.hpp
--- a/src/hotspot/cpu/arm/vm_version_arm.hpp    Wed Oct 17 19:11:11 2018 +0200
+++ b/src/hotspot/cpu/arm/vm_version_arm.hpp    Wed Oct 17 19:44:13 2018 +0200
@@ -110,7 +110,6 @@
   static bool supports_kuser_cmpxchg64() { return _kuser_helper_version >= KUSER_VERSION_CMPXCHG64; }
   // Override Abstract_VM_Version implementation
   static bool use_biased_locking();
-  static const char* vm_info_string();

   static bool has_vfp()             { return (_features & vfp_m) != 0; }
   static bool has_vfp3_32()         { return (_features & vfp3_32_m) != 0; }


Testing: Linux arm32 build

Thanks,
-Aleksey



More information about the hotspot-runtime-dev mailing list