RFR: 8212663: Remove conservative at_safepoint assert when JFR writes type sets during class unloading

David Holmes david.holmes at oracle.com
Fri Oct 19 01:51:59 UTC 2018


Hi Erik,

On 19/10/2018 1:00 AM, Erik Österlund wrote:
> Hi,
> 
> JFR writes type sets during class unloading. It currently asserts this 
> is done in a safepoint. But in fact, it suffices that it is done by a 
> single thread. This assert needs to be relaxed for concurrent class 
> unloading.

Okay but you removed it completely. Is there not something you can 
assert to verify your single thread requirement:

Thread::current()->is_VM_thread() || Thread::current()->is_ 
classUnloader_thread()

??

Cheers,
David

> Webrev:
> http://cr.openjdk.java.net/~eosterlund/8212663/webrev.00/
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8212663
> 
> Thanks,
> /Erik


More information about the hotspot-runtime-dev mailing list