RFR(two-liner): 8212707: GlobalCounter padding is too optimistic

Robbin Ehn robbin.ehn at oracle.com
Mon Oct 22 11:13:35 UTC 2018


Thanks for reviewing and spotting it!

/Robbin

On 10/22/18 1:06 PM, Aleksey Shipilev wrote:
> On 10/22/2018 01:06 PM, Robbin Ehn wrote:
>> diff -r bca2b63dd839 src/hotspot/share/utilities/globalCounter.hpp
>> --- a/src/hotspot/share/utilities/globalCounter.hpp    Mon Oct 22 14:08:07 2018 +0800
>> +++ b/src/hotspot/share/utilities/globalCounter.hpp    Mon Oct 22 11:48:17 2018 +0200
>> @@ -48,1 +48,1 @@
>> -    DEFINE_PAD_MINUS_SIZE(0, DEFAULT_CACHE_LINE_SIZE/2, 0);
>> +    DEFINE_PAD_MINUS_SIZE(0, DEFAULT_CACHE_LINE_SIZE, 0);
>> @@ -50,1 +50,1 @@
>> -    DEFINE_PAD_MINUS_SIZE(1, DEFAULT_CACHE_LINE_SIZE/2, sizeof(volatile uintx));
>> +    DEFINE_PAD_MINUS_SIZE(1, DEFAULT_CACHE_LINE_SIZE, sizeof(volatile uintx));
> 
> Looks good!
> 
> -Aleksey
> 


More information about the hotspot-runtime-dev mailing list