RFR(XS): 8212883: Setting a double manageable flag with jcmd/jinfo crashes the JVM
Tony Printezis
tprintezis at twitter.com
Tue Oct 23 22:13:53 UTC 2018
Webrev here:
http://cr.openjdk.java.net/~tonyp/8212883/webrev.0/
Currently, HotSpot doesn’t actually have any double manageable flags, which
is why I think no-one has hit this before. I recently added a couple to our
own builds and I noticed that setting them is not handled correctly in the VM.
The fix is pretty trivial (mostly cut-and-paste from what the code does for
the other types).
I tested it by introducing a dummy double manageable flag and I can set it
with jinfo/jcmd and jconsole (these cover all the various paths in the
changes). Is it worth expanding the
serviceability/attach/AttachSetGetFlag.java test to also get/set a double
flag (I’d need to introduce a dummy double manageable flag to do that
though)?
Regards,
Tony
—————
Tony Printezis | @TonyPrintezis | tprintezis at twitter.com
More information about the hotspot-runtime-dev
mailing list