RFR(xxs): 8212913: (Nested)ThreadsListHandleInErrorHandlingTest need to disable ShowRegistersOnAssert

Doerr, Martin martin.doerr at sap.com
Wed Oct 24 12:12:02 UTC 2018


Looks good. You can push it (after removing the extra space).

Thanks,
Martin


-----Original Message-----
From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net> On Behalf Of Thomas Stüfe
Sent: Mittwoch, 24. Oktober 2018 13:42
To: David Holmes <david.holmes at oracle.com>
Cc: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
Subject: Re: RFR(xxs): 8212913: (Nested)ThreadsListHandleInErrorHandlingTest need to disable ShowRegistersOnAssert

Thanks David!

On Wed, Oct 24, 2018, 13:41 David Holmes <david.holmes at oracle.com> wrote:

> Hi Thomas,
>
>   //  which
>
> There's an extra space before which. :)
>
> Otherwise seems fine - and trivial. No need to see updated webrev.
>
> Thanks,
> David
>
> On 24/10/2018 9:16 PM, Thomas Stüfe wrote:
> > Hi all,
> >
> > may I please have reviews for this smallish patch.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212913
> > cr:
> http://cr.openjdk.java.net/~stuefe/webrevs/8212913-fix-ThreadsListHandleInErrorHandlingTest-with-ShowRegistersOnAssert/webrev.00/webrev/
> >
> > This patch fixes NestedThreadsListHandleInErrorHandlingTest and
> > ThreadsListHandleInErrorHandlingTest when run with
> > -XX:+ShowRegistersOnAssert. Please see bug description for further
> > details.
> >
> > Thanks, Thomas
> >
>


More information about the hotspot-runtime-dev mailing list