RFR(xxs): 8212913: (Nested)ThreadsListHandleInErrorHandlingTest need to disable ShowRegistersOnAssert
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Oct 24 14:21:24 UTC 2018
No worries. Since I wrote those tests, I figured I should
chime in on the review thread... :-)
Dan
On 10/24/18 10:14 AM, Thomas Stüfe wrote:
> Thank you Daniel. I already pushed under the trivial rule, since David
> indicated its trivial :) so it is too late to add you as reviewer.
>
> Cheers, Thomas
> On Wed, Oct 24, 2018 at 4:02 PM Daniel D. Daugherty
> <daniel.daugherty at oracle.com> wrote:
>> On 10/24/18 7:16 AM, Thomas Stüfe wrote:
>>> Hi all,
>>>
>>> may I please have reviews for this smallish patch.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8212913
>>> cr: http://cr.openjdk.java.net/~stuefe/webrevs/8212913-fix-ThreadsListHandleInErrorHandlingTest-with-ShowRegistersOnAssert/webrev.00/webrev/
>> test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java
>> No comments.
>>
>> test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java
>> No comments.
>>
>> Thumbs up.
>>
>> Dan
>>
>>
>>> This patch fixes NestedThreadsListHandleInErrorHandlingTest and
>>> ThreadsListHandleInErrorHandlingTest when run with
>>> -XX:+ShowRegistersOnAssert. Please see bug description for further
>>> details.
>>>
>>> Thanks, Thomas
More information about the hotspot-runtime-dev
mailing list