RFR 8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51

Harold David Seigel harold.seigel at oracle.com
Fri Oct 26 19:13:39 UTC 2018


Hi Coleen,

Thanks for the review!

Harold


On 10/26/2018 2:21 PM, coleen.phillimore at oracle.com wrote:
>
> This looks really good to me.  I'm not sure if you're the winner of 
> the CDE (Code Deletion Engineer) award if it's generated checked in 
> code, but it's very nice.
> Thanks!
> Coleen
>
> On 10/26/18 1:40 PM, Harold David Seigel wrote:
>> Hi,
>>
>> Please review this change to remove the defmeth tests for class file 
>> versions 50 and 51 because these tests are redundant with the defmeth 
>> tests for class file version 52.  The change removes 320 tests and 
>> 14000+ lines of testing code.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8212997/webrev/
>>
>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8212997
>>
>> The change was tested on Linux X64, Windows, Solaris, and Mac.
>>
>> Thanks, Harold
>>
>



More information about the hotspot-runtime-dev mailing list