RFR(XS): 8212154: [TESTBUG] CheckArchivedModuleApp fails with NPE when JVMCI is absent
Calvin Cheung
calvin.cheung at oracle.com
Mon Oct 29 20:37:29 UTC 2018
Harold, Jiangli,
Thanks for your quick review.
Calvin
On 10/29/18, 1:34 PM, Jiangli Zhou wrote:
> +1
>
> Thanks,
>
> Jiangli
>
>
> On 10/29/18 1:32 PM, Harold David Seigel wrote:
>> Hi Calvin,
>>
>> The fix looks good and trivial.
>>
>> Thanks, Harold
>>
>>
>> On 10/29/2018 4:30 PM, Calvin Cheung wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8212154
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8212154/webrev.00/
>>>
>>> The ArchivedModuleComboTest.java and the
>>> ArchivedModuleWithCustomImageTest.java failed with NPE if tested
>>> with a JDK build without JVMCI. A fix is to add a null check on
>>> wb.getBooleanVMFlag("EnableJVMCI").
>>>
>>> Testing:
>>> Ran the 2 tests locally on linux-x64 with JDK builds (with and
>>> without JVMCI).
>>>
>>> thanks,
>>> Calvin
>>
>
More information about the hotspot-runtime-dev
mailing list