RFR[XS] 8210246 NMTUtil::_memory_type_names should be in sync with MemoryType

[Ioi Lam]

Hi Calvin, Jiangli & Coleen,

Thanks for the review. I've fixed the comments and pushed.

- Ioi


On 8/31/18 7:56 AM, coleen.phillimore at oracle.com wrote:
>
> Yes, I had the same comment.
> Hooray for X macros.
> Looks good.
> Coleen
>
> On 8/30/18 8:15 PM, Jiangli Zhou wrote:
>> Looks good. Could you please align the ending '\' for the following 
>> lines. No additional webrev needed for the formatting change.
>>
>>  111   /* Memory type by sub systems. It occupies lower byte. */ \
>>  112   f(mtJavaHeap,      "Java Heap")   /* Java heap */ \
>>  113   f(mtClass,         "Class")       /* Java classes */ \
>>  114   f(mtThread,        "Thread")      /* thread objects */ \
>>  115   f(mtThreadStack,   "Thread Stack") \
>>  116   f(mtCode,          "Code")        /* generated code */ \
>>
>>
>> Thanks,
>> Jiangli
>>
>> On 8/30/18 4:57 PM, Ioi Lam wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8210246
>>> http://cr.openjdk.java.net/~iklam/jdk12/8210246-memory_type_names.v01/
>>>
>>> This is a small clean up:
>>>
>>> MemoryType and _memory_type_names should be in sync, but they were
>>> coded independently in 2 files, and it's possible to change one while
>>> forgetting to change the other.
>>>
>>> The fix is, as always, some fancy macros.
>>>
>>> Thanks
>>> - Ioi
>>
>