RFR(S): 8210514: Obsolete SyncVerbose

[Daniel D. Daugherty]

On 9/7/18 5:41 PM, coleen.phillimore at oracle.com wrote:
>
> I think this looks good. I think as a future RFE we should add logging 
> judiciously to this code and not preserve the logging that's already 
> there.  The new logging for this code should look like the log_debug() 
> etc calls and not with this distracting TEVENT macro.

Just to clarify:

That "distracting TEVENT macro" has an atomic event counter that is
part of the logging output so that the person doing the debugging
knows the sequence of TEVENT calls. When dealing with multi-threaded
output, the system doesn't always issue the output in the same order
in which the various threads generate it...

Dan

>
> Thanks,
> Coleen
>
> On 9/7/18 5:14 PM, Mikael Vidstedt wrote:
>> Please review this change which obsoletes the SyncVerbose flag.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210514 
>> <https://bugs.openjdk.java.net/browse/JDK-8210514>
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8210514/webrev.00/open/webrev/ 
>> <http://cr.openjdk.java.net/~mikael/webrevs/8210514/webrev.00/open/webrev/> 
>>
>>
>> * Background (from bug)
>>
>> The experimental SyncVerbose flag can in theory be used to produce 
>> logging of some synchronization primitives. The flag was convenient 
>> when the synchronization implementation was implemented and tuned a 
>> long time ago.
>>
>> The SyncVerbose flag no longer serves the purpose it used to, and is 
>> "Unstable" (the documentation of the flag says so explicitly). It 
>> should be obsoleted and later removed.
>>
>>
>> Testing: I’m running the normal tier1 testing (still in progress).
>>
>> Cheers,
>> Mikael
>>
>