RFR 8210300: runtime/MemberName/MemberNameLeak.java fails with RuntimeException

[Daniel D. Daugherty]

On 9/10/18 9:57 AM, Patricio Chilano wrote:
> Hi all,
>
> Could you review this small fix to tests CleanProtectionDomain.java 
> and MemberNameLeak.java?
> It adds flag UnlockDiagnosticVMOptions needed in product builds. It 
> also calls System.gc() periodically to avoid relaying on a single 
> call, and adds a short sleep between polls.
>
> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8210300
> Webrev URL: http://cr.openjdk.java.net/~pchilanomate/8210300.01/webrev

test/hotspot/jtreg/runtime/Dictionary/CleanProtectionDomain.java
     L78:       while(true) {
     L81:         if(removedCountOrig != removedCount) break;
         nit - need a space before '(' on each line

test/hotspot/jtreg/runtime/MemberName/MemberNameLeak.java
     L61:         while(true) {
     L64:           if(removedCountOrig != removedCount) break;
         nit - need a space before '(' on each line

I'm curious: why change from a do-while loop to a "while (true)"
loop with an if-statement break?

Thumbs up! I don't need to see a new webrev for fixing the nits.

Dan


>
> Thanks,
> Patricio