RFR 8210422: runtime/modules/ModuleStress/ExportModuleStressTest.java - assertion failed: address not aligned: 0x00000008baadbabe

[coleen.phillimore at oracle.com]

On 9/10/18 11:55 AM, Lois Foltan wrote:
> On 9/10/2018 9:37 AM, coleen.phillimore at oracle.com wrote:
>
>> Summary: CLDG_lock caused safepoint in inconsistent state
>>
>> See bug comments for more details.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8210422.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8210422
>>
>> Tested with mach5 hs-tier1-7.  There are good parallel class loading 
>> tests that test this code.  Unfortunately these tests aren't open yet.
>>
>> Thanks,
>> Coleen
>
> Looks good.  Minor comment:
>
> share/classfile/classLoaderData.cpp:
> line #1127 - you removed the comment "because adding the Symbol for 
> _name and _name_and_id might safepoint".  Isn't that still the case?  
> If not, then why are we initializing those fields after the loader 
> data has been added to the CLDG and not before?

I removed the comment because SymbolTable::new_symbol() doesn't 
safepoint anymore.  Gerard made SymbolTable_lock into SymbolArena_lock 
that doesn't check for safepoint.  But I thought it was best to keep the 
initializing name code where it was, in case it ever safepointed again.

thanks,
Coleen

>
> Thanks,
> Lois