RFR 8027434: "-XX:OnOutOfMemoryError" uses fork instead of vfork

[Muthusamy Chinnathambi]

Hi David,

Please find the updated webrev at http://cr.openjdk.java.net/~mchinnathamb/8027434/webrev.01/ 
Instead of creating a static helper, I have moved the decision to the fork_and_exec routine itself.

Tested with mach5 hs-tier1-4.

Regards,
Muthusamy C

-----Original Message-----
From: Muthusamy Chinnathambi 
Sent: Friday, September 14, 2018 12:03 PM
To: David Holmes <david.holmes at oracle.com>; hotspot-runtime-dev at openjdk.java.net
Subject: RE: RFR 8027434: "-XX:OnOutOfMemoryError" uses fork instead of vfork

Hi David,

> please refactor into a static helper function
Sure, I will change and get back after testing.

Regards,
Muthusamy C

-----Original Message-----
From: David Holmes 
Sent: Friday, September 14, 2018 11:16 AM
To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR 8027434: "-XX:OnOutOfMemoryError" uses fork instead of vfork

Hi Muthusamy,

Instead of duplicating all the code - which I think only differs in the 
fork versus vfork line - please refactor into a static helper function 
that takes a boolean vfork and call that from 
fork_and_exec/vfork_and_exec selecting fork or vfork as appropriate.

I'm still mulling over whether there is a cleaner way to do this other 
than introducing a linux only entry to the os class.

Thanks,
David


On 14/09/2018 1:55 PM, Muthusamy Chinnathambi wrote:
> Hi all,
> 
> Could you review this fix for JDK-8027434 - to use vfork instead of fork for -XX:OnOutOfMemoryError.
> 
> See bug comments for more details.
> 
> Bug URL: https://bugs.openjdk.java.net/browse/JDK-8027434
> Webrev URL: http://cr.openjdk.java.net/~mchinnathamb/8027434/webrev.00/
> 
> Tested with mach5 hs-tier1-4.
> 
> Regards,
> Muthusamy C
>