RFR (S) 8198717: Remove compute_optional_offset

Claes Redestad claes.redestad at oracle.com
Wed Sep 19 16:11:22 UTC 2018


+1

On 2018-09-19 17:19, coleen.phillimore at oracle.com wrote:
>
>
> On 9/19/18 9:51 AM, Claes Redestad wrote:
>> Nice cleanup!
>>
>> I think setting these previously optional offsets to -1 in the 
>> compute_offset methods is now pointless. I suggest removing that 
>> along with the legacy comments (".. only present in 1.5") and related 
>> asserts.
>
> Yeah, you're right. I don't need this.  The vm will not start if these 
> fields are not found.  Thank you for reviewing this!
>
> http://cr.openjdk.java.net/~coleenp/8198717.02/webrev
>
> Sorry not incremental.  Retesting in progress.
>
> thanks!
> Coleen 



More information about the hotspot-runtime-dev mailing list