RFR (S) 8198717: Remove compute_optional_offset

[coleen.phillimore at oracle.com]

Thanks Claes.
Coleen

On 9/19/18 12:11 PM, Claes Redestad wrote:
> +1
>
> On 2018-09-19 17:19, coleen.phillimore at oracle.com wrote:
>>
>>
>> On 9/19/18 9:51 AM, Claes Redestad wrote:
>>> Nice cleanup!
>>>
>>> I think setting these previously optional offsets to -1 in the 
>>> compute_offset methods is now pointless. I suggest removing that 
>>> along with the legacy comments (".. only present in 1.5") and 
>>> related asserts.
>>
>> Yeah, you're right. I don't need this.  The vm will not start if 
>> these fields are not found.  Thank you for reviewing this!
>>
>> http://cr.openjdk.java.net/~coleenp/8198717.02/webrev
>>
>> Sorry not incremental.  Retesting in progress.
>>
>> thanks!
>> Coleen 
>