RFR: 8210889: Some service thread cleanups can be starved

Thomas Schatzl thomas.schatzl at oracle.com
Wed Sep 19 21:00:37 UTC 2018


Hi,
> > [...]
> > Looks good. Maybe the comment could be improved because it does not
> > answer why we do not want short-circuiting in this case. It only
> > seems
> > to describe what the code does.
> > 
> > Thanks,
> >  Thomas
> 
> Sure, I can do that:
> 
> // Process all available work on each (outer) iteration, rather than
> // only the first recognized bit of work, to avoid frequently true 
> // early tests from potentially starving later work.  Hence the use
> // of arithmetic-or to combine results; we don't want short-
> // circuiting.
> 
> Thanks for reviewing.
> 

Looks good (if needed).

Thomas




More information about the hotspot-runtime-dev mailing list