RFR (XXS): 8211045: [Testbug] Fix for 8144279 didn't define a test case!

Aleksey Shipilev shade at redhat.com
Mon Sep 24 08:18:36 UTC 2018


On 09/24/2018 10:13 AM, Severin Gehwolf wrote:
> On Sun, 2018-09-23 at 11:52 -0400, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8211045
>> webrev: http://cr.openjdk.java.net/~dholmes/8211045/webrev/
>>
>> It looks like the original fix forgot to hg add a new test file:
>>
>> http://cr.openjdk.java.net/~gthornbr/8144279/webrev.00/raw_files/new/test/runtime/jsig/Testjsig.java
>>
>> So we add that now with some minor edits to update test library usage 
>> and drop unnecessary -server arg.
>>
>> Testing: itself
> 
> Test exercises code which was dead prior this patch. Looks good. I'm
> not a Reviewer.

I am. Looks good!

-Aleksey



More information about the hotspot-runtime-dev mailing list