RFR(S): 8211124: HotSpot update for vm_version.cpp to recognise updated VS2017

Lois Foltan lois.foltan at oracle.com
Wed Sep 26 12:36:54 UTC 2018


+1
Lois

On 9/26/2018 7:44 AM, David Holmes wrote:
> Looks fine Kevin!
>
> Thanks,
> David
>
> On 26/09/2018 6:46 AM, Kevin Walls wrote:
>> Hi,
>>
>> I'd like to get a review for a simple update to make hotspot aware of 
>> an additional Windows compiler version, for use in its long version 
>> info string (and in hs_err crash reports).
>>
>> 8211124: HotSpot update for vm_version.cpp to recognise updated VS2017
>> https://bugs.openjdk.java.net/browse/JDK-8211124
>>
>> Thanks
>> Kevin
>>
>> bash-4.2$ hg diff
>> diff -r a6bdb6d5f167 src/hotspot/share/runtime/vm_version.cpp
>> --- a/src/hotspot/share/runtime/vm_version.cpp  Tue Sep 25 11:31:55 
>> 2018 -0700
>> +++ b/src/hotspot/share/runtime/vm_version.cpp  Wed Sep 26 03:34:17 
>> 2018 -0700
>> @@ -220,6 +220,8 @@
>>           #define HOTSPOT_BUILD_COMPILER "MS VC++ 14.0 (VS2015)"
>>         #elif _MSC_VER == 1912
>>           #define HOTSPOT_BUILD_COMPILER "MS VC++ 15.5 (VS2017)"
>> +      #elif _MSC_VER == 1913
>> +        #define HOTSPOT_BUILD_COMPILER "MS VC++ 15.6 (VS2017)"
>>         #else
>>           #define HOTSPOT_BUILD_COMPILER "unknown MS VC++:" 
>> XSTR(_MSC_VER)
>>         #endif
>> bash-4.2$
>>
>>



More information about the hotspot-runtime-dev mailing list