RFR (XS) 8221918: runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java fails: Shared archive not found

[Aleksey Shipilev]

On 4/3/19 5:24 PM, Aleksey Shipilev wrote:
> Test bug:
>   https://bugs.openjdk.java.net/browse/JDK-8221918
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8221918/webrev.01/
> 
> It seems the test is running with -Xshare:auto, which expects the CDS archive to be generated by
> default during the build? x86_32 fails with "Shared archive not found" in that test, and it fails
> tier1 then.
> 
> Dumping the CDS archive before starting the test helps those configs where archive is not created
> automatically. I copy-pasted the new block from the test (later in the same file) and dropped some
> non-essentials.

On a second thought, I think we are better using test-specific archive to avoid problems with other
CDS tests that might also expect archive to be generated (which would break them when they run
standalone) or read the shared archive while it is being generated.

New webrev:
  http://cr.openjdk.java.net/~shade/8221918/webrev.02/

Testing: affected test on Linux {x86_64, x86_32} fastdebug, jdk-submit (running)

-Aleksey