RFR (XS) 8221918: runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java fails: Shared archive not found

Aleksey Shipilev shade at redhat.com
Wed Apr 3 17:45:40 UTC 2019


On 4/3/19 7:37 PM, Jiangli Zhou wrote:
> Looks like we were going to the same direction. I sent out the review before seeing your second
> version. This looks okay to me.

Yes! Thanks for review.

I have not noticed there CDSTestUtils.createArchive, I guess explicit setArchiveName is as good.
I'll wait for jdk-submit to clear webrev.02 for me and wait for another review maybe.

-Aleksey

>     New webrev:
>       http://cr.openjdk.java.net/~shade/8221918/webrev.02/



More information about the hotspot-runtime-dev mailing list