RFR (T) 8221872: Remove ClassLoaderWeakHandle typedef
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Apr 4 01:12:40 UTC 2019
On 4/3/19 8:47 PM, David Holmes wrote:
> Hi Coleen,
>
> On 4/04/2019 10:42 am, coleen.phillimore at oracle.com wrote:
>>
>> I changed the description of the bug to:
>>
>> 8221872: Remove uses of ClassLoaderWeakHandle typedef in protection
>> domain table
>>
>> The typedef will be removed with this change JDK-8221393
>> <https://bugs.openjdk.java.net/browse/JDK-8221393>ResolvedMethodTable
>> too small for StackWalking applications
>
> Personally I find the typedef improves readability - especially with
> parameterized types. But okay ... the removal of these uses of the
> typedef in anticipation of its removal seems fine.
Thanks for the code review. This doesn't have too many <> parameterized
types so it's not so bad.
Coleen
>
> Thanks,
> David
>
>> Thanks,
>> Coleen
>>
>> On 4/3/19 8:00 PM, coleen.phillimore at oracle.com wrote:
>>> Summary: Make consistent with StringTable and ResolvedMethodTable
>>>
>>> We decided to not have this typedef because StringTable doesn't have
>>> it and the new concurrent hashtable for ResolvedMethodTable won't
>>> either. This will make it consistent.
>>>
>>> Tested with hs tier1 on Oracle platforms.
>>>
>>> open webrev at
>>> http://cr.openjdk.java.net/~coleenp/2019/8221872.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8221872
>>>
>>> Thanks,
>>> Coleen
>>>
>>
More information about the hotspot-runtime-dev
mailing list