RFR (S): 8218458: [TESTBUG] runtime/NMT/CheckForProperDetailStackTrace.java fails with Expected stack trace missing from output

Zhengyu Gu zgu at redhat.com
Thu Apr 4 14:36:01 UTC 2019



On 4/4/19 1:53 AM, David Holmes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218458
> Webrev: http://cr.openjdk.java.net/~dholmes/8218458/webrev/
> 
> The actual stack trace reported by NMT detail is affected by the 
> inlining decisions of the native compiler, and on the type of build. So 
> we define an "ideal" stacktrace and then allow for some frames to be 
> missing based on empirical observations. So to date we have seen two 
> frames that may or may not be inlined and so we allow for 2 non-matching 
> entries.
> 
> The special-casing of AllocateHeap is removed as now it is just an 
> optional frame.
> 
> Chris: does this maintain the "spirit" of the test as you intended?
> 
> Zhengyu: can you test this on your system(s) please.

Passed!

Thanks,

-Zhengyu

> 
> Thanks,
> David


More information about the hotspot-runtime-dev mailing list