RFR (XS) 8221918: runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java fails: Shared archive not found

[David Holmes]

On 4/04/2019 6:21 pm, Aleksey Shipilev wrote:
> On 4/4/19 2:12 AM, David Holmes wrote:
>> There's no error checking in the dump part - if something goes wrong we won't see anything to
>> indicate what it was, and AFAICS we won't even notice the failure (till the second part of the test).
> 
> Right. This should help:
> 
> -            CDSTestUtils.run(opts);
> +            CDSTestUtils.run(opts).assertNormalExit("");

Okay.

> 
>> Aside: not sure why we can't just use:
>> @run main/othervm -XX:SharedArchiveFile=... -Xshare:dump
>> and let jtreg deal with error?
> 
> We technically can, but then we would lose the ability to generate shared archive file name, and
> would need to add the same line to the test subclasses, e.g ReplaceCriticalClassesForSubgraphs.java

Okay.

>> Please update copyright to "2018, 2019,"
> 
> Updated.
> 
> New webrev:
>   http://cr.openjdk.java.net/~shade/8221918/webrev.03/

Looks fine.

Thanks,
David
-----

> -Aleksey
>