RFR(XS): 8221833: Readability check in Symbol::is_valid not performed for some addresses

[Doerr, Martin]

Thank you for the reviews!
Martin


-----Original Message-----
From: coleen.phillimore at oracle.com <coleen.phillimore at oracle.com> 
Sent: Donnerstag, 4. April 2019 20:27
To: Zhengyu Gu <zgu at redhat.com>; Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8221833: Readability check in Symbol::is_valid not performed for some addresses

+1
thanks,
Coleen

On 4/4/19 10:55 AM, Zhengyu Gu wrote:
>
>
> On 4/4/19 10:42 AM, Doerr, Martin wrote:
>> Hi Coleen and Zhengyu,
>>
>> thanks for your feedback. I've also replaced pointer comparison by 
>> numeric comparison to avoid undefined behavior.
>>
>> New webrev:
>> http://cr.openjdk.java.net/~mdoerr/8221833_valid_symbol/webrev.01/
>
> Looks good.
>
> Thanks,
>
> -Zhengyu
>
>>
>> Best regards,
>> Martin
>>
>>
>> -----Original Message-----
>> From: hotspot-runtime-dev 
>> <hotspot-runtime-dev-bounces at openjdk.java.net> On Behalf Of 
>> coleen.phillimore at oracle.com
>> Sent: Donnerstag, 4. April 2019 02:33
>> To: hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8221833: Readability check in Symbol::is_valid 
>> not performed for some addresses
>>
>>
>>
>> On 4/2/19 10:33 AM, Doerr, Martin wrote:
>>> Hi Zhengyu,
>>>
>>> that would be fine, too. I'll put it there if other reviewers prefer 
>>> that, too.
>>
>> Yes, I prefer that too.
>> Coleen
>>
>>>
>>> Thanks and best regards,
>>> Martin
>>>
>>>
>>> -----Original Message-----
>>> From: Zhengyu Gu <zgu at redhat.com>
>>> Sent: Dienstag, 2. April 2019 16:01
>>> To: Doerr, Martin <martin.doerr at sap.com>; 
>>> hotspot-runtime-dev at openjdk.java.net
>>> Subject: Re: RFR(XS): 8221833: Readability check in Symbol::is_valid 
>>> not performed for some addresses
>>>
>>> Hi Martin,
>>>
>>> Would it be more proper to do the check in os::is_readable_range()?
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>> On 4/2/19 9:05 AM, Doerr, Martin wrote:
>>>> Hi,
>>>>
>>>> I'd like to fix a minor bug in Symbol::is_valid which can cause 
>>>> errors during error reporting:
>>>> Address computation can overflow leading to skipped readability check.
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8221833
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~mdoerr/8221833_valid_symbol/webrev.00/
>>>>
>>>> Please review.
>>>>
>>>> Best regards,
>>>> Martin
>>>>
>>