RFR (S) 8222231: Clean up interfaceSupport.inline.hpp duplicated code

Patricio Chilano patricio.chilano.mateo at oracle.com
Wed Apr 10 16:01:33 UTC 2019


Hi Coleen!

Change looks good to me! Just a small comment. Since we now will not 
clear unhandled oops in the TBIVMWDC jacket anymore, I think we should 
add that check in Monitor::wait() like we do in Monitor::lock().

Thanks!
Patricio

On 4/10/19 10:36 AM, coleen.phillimore at oracle.com wrote:
>
> Thank you David!
> Coleen
>
> On 4/9/19 10:04 PM, David Holmes wrote:
>> Hi Coleen,
>>
>> Thanks for doing this! It is all a lot simpler now. Reviewed with 
>> enthusiasm. :)
>>
>> David
>>
>> On 10/04/2019 9:58 am, coleen.phillimore at oracle.com wrote:
>>> Some code was left from removing code UseMembar and further 
>>> improvements encouraged by dholmes.  I also removed a couple 
>>> redundant and unneeded clear_unhandled_oops calls.  The one in 
>>> ThreadBlockInVMWithDeadlockCheck is in the calling code 
>>> Monitor::lock, and the thread in vm from native makes no sense.
>>>
>>> Tested with runtime jtreg tests, and mach5 tier1-3 in progress.
>>>
>>> open webrev at 
>>> http://cr.openjdk.java.net/~coleenp/2019/8222231.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8222231
>>>
>>> Thanks,
>>> Coleen
>



More information about the hotspot-runtime-dev mailing list